fix: Workaround for clip with modin[pyarrow] and cudf backends
#2986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
commented
Aug 13, 2025
FBruzzesi
changed the title
clip with modin[pyarrow] backendclip with modin[pyarrow] and cudf backends
FBruzzesi
commented
Aug 14, 2025
10 tasks
dangotbanned
approved these changes
Aug 15, 2025
There was a problem hiding this comment.
Thanks @FBruzzesi!
The two suggestions I've left are dependent - but GH wouldn't let me use a single suggestion
narwhals/_pandas_like/series.py
Outdated
| lower_bound: Self | NumericLiteral | TemporalLiteral | None, | ||
| upper_bound: Self | NumericLiteral | TemporalLiteral | None, | ||
| ) -> Self: | ||
| native = self.native |
There was a problem hiding this comment.
Needs to be done with the other suggestion, but out of range 😢
Suggested change
| native = self.native |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
assert_series_equal#2983 (comment)Checklist
If you have comments or can explain your changes, please do so below